in get_structured_config_data: check for dict subclass data #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasha10
commented
Mar 30, 2021
Comment on lines
907
to
911
| def test_dict_subclass_data_preserved_upon_node_creation(self, module: Any) -> None: | ||
| src = module.DictSubclass.Str2Str() | ||
| src["baz"] = "qux" | ||
| cfg = OmegaConf.structured(src) | ||
| assert cfg.baz == "qux" |
There was a problem hiding this comment.
If run against the master branch, the above test raises ConfigAttributeError: Missing key baz.
This PR addresses the error by inspecting for dict subclass data within the get_attr_data and get_dataclass_data functions.
omry
requested changes
Mar 31, 2021
omry
reviewed
Apr 2, 2021
|
omry
requested changes
Apr 8, 2021
|
Should be ready to go :) |
omry
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #584
TODO:
test_errors.pyfor the newtry: ... except ValidationError: ...code path.